Add Tuya siren _TZE204_fncxk3ob variant
#3545
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilipParyz
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3545 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 314 314
Lines 10243 10243
=======================================
Hits 9181 9181
Misses 1062 1062 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
TheJulianJES
added
Tuya
TheJulianJES
changed the title
_TZE204_fncxk3ob variant
|
Hi @TheJulianJES ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds support for additional Siren variant and fixes issue #3180
Additional information
This is my first contribution to the ZigPy repo. I used PR #3361 as a guide how and where I should add the Siren variant. I have not tested it locally, but would be glad to do so once guided.
Checklist
pre-commitchecks pass / the code has been formatted using Black